-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP-3710 create new custom calldata L1 gas oracle #14710
base: chore/move-da-oracle-config-consts
Are you sure you want to change the base?
CCIP-3710 create new custom calldata L1 gas oracle #14710
Conversation
WF: CI Core#528e80aNo errors found in this run. 🎉 |
9cdbf76
to
41b5cb9
Compare
func (d *daOracleConfig) CustomGasPriceCalldata() string { | ||
// TODO: CCIP-3710 update once custom calldata oracle is added | ||
return "" | ||
if d.c.OracleType != toml.CustomCalldata { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels off, maybe we can move the Oracle constants into a child daoracle
package, or prepend them, smt like DAOracle_CustomCalldata
logger logger.SugaredLogger | ||
|
||
daOracleConfig evmconfig.DAOracle | ||
l1GasPriceMu sync.RWMutex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove all references to l1
and use da
instead
e33bf1e
to
6ab6540
Compare
41b5cb9
to
6c8b7f5
Compare
6c8b7f5
to
528e80a
Compare
528e80a
to
69ab245
Compare
Quality Gate failedFailed conditions See analysis details on SonarQube Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
As a follow up to #14599, this PR adds a separate custom L1 oracle specifically for fetching gas prices from a custom contract method rather than baking the logic into the existing OP stack L1 oracle